Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rhino app template unit test #539

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

radbasa
Copy link
Contributor

@radbasa radbasa commented Jan 12, 2024

Changes

How to test

  • github actions CI/CD should pass.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (987c967) 17.82% compared to head (1f62121) 17.82%.

❗ Current head 1f62121 differs from pull request most recent head 18a4031. Consider uploading reports for the commit 18a4031 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           dev_next     #539   +/-   ##
=========================================
  Coverage     17.82%   17.82%           
=========================================
  Files             9        9           
  Lines           404      404           
=========================================
  Hits             72       72           
  Misses          332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radbasa radbasa marked this pull request as ready for review January 12, 2024 04:33
@radbasa radbasa merged commit 321e6ee into dev_next Jan 12, 2024
20 checks passed
@radbasa radbasa deleted the update/app-box-use-style branch January 12, 2024 04:35
radbasa added a commit that referenced this pull request Feb 5, 2024
* future dev branch

* update rhino app template unit test (#539)

* update rhino app template unit test

* update e2etest app files

* remove what looks like stylr styling

* one version too far

* Box universal import linter (#533)

* box universal import linter

* add box_universal_import_linter to .lintr template

* documentation

* package housekeeping

* removed some lint

* namespace box_universal_import_linter

* reordered Suggests

* update e2etest app files to rhino-box styleguide

* address comments/suggestions in PR

* fixed version number issue. moved xml2 to imports

* chore: Update NEWS and add Rodrigo to authors.

---------

Co-authored-by: Jakub Nowicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants